Add flaky retry on CalcitePPLTpchIT#4060
Merged
LantaoJin merged 3 commits intoopensearch-project:mainfrom Aug 21, 2025
Merged
Conversation
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
added
flaky-test
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
changed the title
LantaoJin
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
qianheng-aws
previously approved these changes
Aug 19, 2025
dai-chen
reviewed
Aug 19, 2025
integ-test/src/test/java/org/opensearch/sql/util/RetryProcessor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lantao Jin <ltjin@amazon.com>
qianheng-aws
approved these changes
Aug 20, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 21, 2025
* Add flaky retry on CalcitePPLTpchIT.testQ7 Signed-off-by: Lantao Jin <ltjin@amazon.com> * Add retry to all tpch queries Signed-off-by: Lantao Jin <ltjin@amazon.com> * address comments Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com> (cherry picked from commit be38740) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 tasks
penghuo
pushed a commit
that referenced
this pull request
Aug 21, 2025
* Add flaky retry on CalcitePPLTpchIT (#4060) * Add flaky retry on CalcitePPLTpchIT.testQ7 Signed-off-by: Lantao Jin <ltjin@amazon.com> * Add retry to all tpch queries Signed-off-by: Lantao Jin <ltjin@amazon.com> * address comments Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com> (cherry picked from commit be38740) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix retry annotation for class Signed-off-by: Lantao Jin <ltjin@amazon.com> * Ignore testQ7 in macOS Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Lantao Jin <ltjin@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CalcitePPLTpchIT.testQ7 failed with socket timeout sometimes on mac/windows instance.
q1 could be flaky when pushdown enabled since the precision of double sum depended on order of data.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.